Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Introduce allocation filter to control placement of search only replicas #15702

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Sep 4, 2024

This is a manual backport of #15455 to 2.x.

2.x line throws a different exception type for validation errors while creating an index (IAE vs SettingsException). This updates the backported tests to the expected type.

mch2 added 2 commits September 4, 2024 15:23
…earch only replicas (opensearch-project#15455)

* Introduce allocation filter to control placement of search only replicas

Signed-off-by: Marc Handalian <[email protected]>

* Add a new decider rather than updating the existing FilterAllocationDecider

Signed-off-by: Marc Handalian <[email protected]>

* Fix license header and description on SearchReplicaAllocationDecider

Signed-off-by: Marc Handalian <[email protected]>

* Pr feedback.

Signed-off-by: Marc Handalian <[email protected]>

* Fix class name to pass precommit checks

Signed-off-by: Marc Handalian <[email protected]>

* Refactor all search replica create/update tests to a single OpenSearchSingleNodeTestCase.

Signed-off-by: Marc Handalian <[email protected]>

* remove changelog entry

Signed-off-by: Marc Handalian <[email protected]>

---------

Signed-off-by: Marc Handalian <[email protected]>
Signed-off-by: Marc Handalian <[email protected]>
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 7d79de3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 7d79de3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 7d79de3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for 2ba2e2c: SUCCESS

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.70%. Comparing base (017f7d4) to head (2ba2e2c).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...cation/decider/SearchReplicaAllocationDecider.java 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15702      +/-   ##
============================================
- Coverage     71.72%   71.70%   -0.03%     
- Complexity    64329    64356      +27     
============================================
  Files          5261     5262       +1     
  Lines        300936   300959      +23     
  Branches      43822    43825       +3     
============================================
- Hits         215854   215799      -55     
- Misses        67024    67143     +119     
+ Partials      18058    18017      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants